Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add a way to verify signature inside the Ts SDK #135

Merged
merged 9 commits into from
Jan 4, 2024

Conversation

Rgascoin
Copy link
Member

Feat: messages signatures can't be only verified on the Aleph's Network
Solution: Add a way to verify signatures directly in the SDK

@Rgascoin Rgascoin added the enhancement New feature or request label Mar 14, 2023
@Rgascoin Rgascoin self-assigned this Mar 14, 2023
@Rgascoin Rgascoin linked an issue Mar 14, 2023 that may be closed by this pull request
@MHHukiewitz MHHukiewitz marked this pull request as ready for review January 3, 2024 16:50
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggestions to make imports cleaner

src/accounts/substrate.ts Outdated Show resolved Hide resolved
src/utils/signature/verifyAvalanche.ts Outdated Show resolved Hide resolved
@MHHukiewitz MHHukiewitz merged commit 32caa63 into main Jan 4, 2024
2 of 5 checks passed
@MHHukiewitz MHHukiewitz deleted the Feat/Protocols/SignVerif branch January 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding signature verification inside the SDK
3 participants