-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add a way to verify signature inside the Ts SDK #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rgascoin
force-pushed
the
Feat/Protocols/SignVerif
branch
from
March 21, 2023 16:40
6656ea7
to
5c761c5
Compare
MHHukiewitz
force-pushed
the
Feat/Protocols/SignVerif
branch
from
January 3, 2024 15:24
d2f6ada
to
d7cf29b
Compare
MHHukiewitz
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with minor suggestions to make imports cleaner
MHHukiewitz
force-pushed
the
Feat/Protocols/SignVerif
branch
from
January 4, 2024 14:54
b2454c9
to
f8c8f78
Compare
Solution: Add a way to verify signatures directly in the SDK
Solution: move verify method into utils/signature
MHHukiewitz
force-pushed
the
Feat/Protocols/SignVerif
branch
from
January 4, 2024 16:07
f8c8f78
to
eeb7a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: messages signatures can't be only verified on the Aleph's Network
Solution: Add a way to verify signatures directly in the SDK