Fix: no HTTPs in IPv4 diagnostic check #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: a node operator reports a timeout when attempting to connect to `https://9.9.9.9`. However, he can ping `9.9.9.9` just fine. Solution: as the diagnostic check is targeted at IPv4 connectivity only, use a socket to attempt to connect to 9.9.9.9:53 directly.
odesenfans
force-pushed
the
od-no-https-in-ipv4-diagnostic-check
branch
from
433cf19
to
2914b89
Compare
hoh
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: a node operator reports a timeout when attempting to connect to
https://9.9.9.9. However, he can ping9.9.9.9just fine.Solution: as the diagnostic check is targeted at IPv4 connectivity only, use a socket to attempt to connect to 9.9.9.9:53 directly.