Fix: Caddyfile syntax broken in 2.7.4 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax of the Caddyfile documented in the quick install guides is broken in Caddy 2.7.4. This removes the unused `on_demand` section from the configuration, restoring compatibility with newer versions of Caddy. We maintain the `on_demand_tls` section in case we may re-enable wildcard domains on the default config.
odesenfans
approved these changes
Sep 18, 2023
hoh
added a commit
that referenced
this pull request
Mar 12, 2024
The syntax of the Caddyfile documented in the quick install guides is broken in Caddy 2.7.4. This removes the unused `on_demand` section from the configuration, restoring compatibility with newer versions of Caddy. We maintain the `on_demand_tls` section in case we may re-enable wildcard domains on the default config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax of the Caddyfile documented in the quick install guides is broken in Caddy 2.7.4.
This removes the unused
on_demandsection from the configuration, restoring compatibility with newer versions of Caddy.We maintain the
on_demand_tlssection in case we may re-enable wildcard domains on the default config.{ on_demand_tls { interval 60s burst 5 } } brain01.crn.alephians.com:443 { - tls { - on_demand - } reverse_proxy http://127.0.0.1:4020 { # Forward Host header to the backend header_up Host {host} } }