Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance code quality checks #411

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Enhance code quality checks #411

merged 2 commits into from
Sep 25, 2023

Conversation

hoh
Copy link
Member

@hoh hoh commented Sep 25, 2023

  • Cleanup: Fix Mypy errors in init1.py
  • Fix: Code quality was not enforced
  • Cleanup: Code quality issues reported by tooling.

@hoh hoh mentioned this pull request Sep 25, 2023
Merged
@hoh
Fix: Code quality was not enforced
637f11b 
Problem: The code quality of the source code and the scripts was not verified automatically and could result into bugs or noisy commits from other contributors when fixing them.

Solution:

1. Add the tool `flake8` to the CI tests and adds code quality on the runtime Python code.

2. Enable Python tests on the runtime init as well.

3. Add `shellcheck` to check the quality of shell scripts.
@hoh hoh force-pushed the hoh-code-quality branch 2 times, most recently from 390ef77 to b92bf7b Compare September 25, 2023 12:45
@hoh
Cleanup: Code quality issues reported by tooling.
ce59549 
This fixes a series of small code quality issues raised by our code quality tools.
@hoh hoh merged commit 6fc4023 into main Sep 25, 2023
13 checks passed
@hoh hoh deleted the hoh-code-quality branch September 25, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hoh