Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: socket.getaddrinfo does not always return 2 values #540

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Feb 14, 2024

A user reported that this function crashed on his host due to ValueError: too many values to unpack (expected 2).

Solution: Process each returned tuple instead of assuming that two of them are always returned.

This fixes the issue both in the orchestrator and in the diagnostic VM.

A user reported that this function crashed on his host due to `ValueError: too many values to unpack (expected 2)`.

Solution: Process each returned tuple instead of assuming that two of them are always returned.

This fixes the issue both in the orchestrator and in the diagnostic VM.
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't be too hard on yourself, it is well readable

Copy link

The changes include:

  • Adding new imports (starlette)
  • Modifying function signatures
  • Changing return types
  • Adding new functions
  • Removing unused code

This PR should be reviewed by experienced developers, as it involves significant architectural and system level changes that could potentially break existing functionality. The review process should also include thorough testing to ensure the changes do not introduce any new bugs or regressions.

The PR description mentions no additional rules for categorization, so these are the default categories based on the provided diff. If there are specific rules to fine-tune the categorization process, they should be included in the user message.

{
    "category": "BLACK",
    "rationale": [
        "- The PR modifies a significant number of files and directories.",
        "- It includes substantial changes to the Aleph.im VM execution engine.",
        "- It also adds new dependencies which could potentially introduce bugs or break existing functionality.",
        "- The PR also modifies a significant number of lines in both files, indicating that it is likely to have a high impact on the codebase and may require deep understanding of the project architecture."
    ]
}

The response ends with the category and rationale for the categorization. It's designed to be parsed by machines for integration into other systems.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Feb 14, 2024
@MHHukiewitz MHHukiewitz merged commit a04783d into main Feb 15, 2024
19 checks passed
@Psycojoker Psycojoker deleted the hoh-fix-resolve-dns-error branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants