-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect already running Persistent VMs #541
Conversation
…tor reboot. Solution: Don't delete the entire table on the start process.
…out of 10 seconds.
RED: The PR includes larger changes that may have moderate risks or require deeper understanding of the project architecture. These changes are likely to introduce minor bugs and should be reviewed by experienced developers.
BLACK: The PR includes extensive changes that have a high potential for introducing bugs or require deep understanding of the project architecture. These changes are likely to introduce significant bugs and should only be reviewed by experienced developers.
Please note that the categorization of PRs can vary depending on specific rules or guidelines set by the team. The above analysis is based on general principles and might not fully capture all potential risks associated with each category. It's recommended to review these changes thoroughly before merging them into the main codebase. |
…rs giving an empty list instead None value.
Problem: Persistent VMs running were not detected after the orchestrator reboot. Solution: Don't delete the entire table on the start process. * Fix: Avoid to wait so long time to stop guest_api process. Put a timeout of 10 seconds. * Fix: Avoid final `cannot unpack non-iterable VmExecution object` errors giving an empty list instead None value. * Fix: If the execution already exist, only continue, not break the loop. --------- Co-authored-by: Andres D. Molins <[email protected]>
Problem: Persistent VMs running were not detected after the orchestrator reboot.
Solution: Don't delete the entire table on the start process. Also added small fixes about guest_api and solved code quality issue.