Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Linux kernel from package could not be on a different device #543

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Feb 14, 2024

If the Linux kernel provided is was another device than the execution root, creating a hardlink within the jailer directory would fail.

Solution: Copy the kernel to the execution root during setup.

If the Linux kernel provided is was another device than the execution root, creating a hardlink within the jailer directory would fail.

Solution: Copy the kernel to the execution root during setup.
Copy link

  • Changes in conf.py file related to VM execution engine setup:
    • Creates directories for execution logs and persistent volumes if they do not exist already.
    • Copies the Linux kernel binary from a different location to the execution root directory, which might be necessary for hardlink creation within jailer directories.

This PR is likely suitable for review by any developer familiar with the project architecture. It should not require deep understanding of specific features or modules unless they are directly related to the changes made in this PR.

User Message

--- aleph-im/aleph ---
Aleph.im platform

Rules: No additional rules provided

Diff:
diff --git a/src/aleph/conf.py b/src/aleph/conf.p

Assistant

I'm sorry, but the diff you provided is incomplete and it seems like there are no changes related to VM execution engine in this PR. Could you please provide more details or complete the diff? I would be happy to help further with your code review categorization.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Feb 14, 2024
src/aleph/vm/conf.py Outdated Show resolved Hide resolved
@nesitor nesitor self-requested a review February 20, 2024 16:49
@hoh hoh merged commit 83b4f9b into main Feb 20, 2024
18 checks passed
@hoh hoh deleted the hoh-kernel-copy branch February 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants