Fix issues with stopping VMs #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hoh
commented
Mar 5, 2024
hoh
commented
- Fix: A VM was only marked as stopping after all runs completed
- Fix: Stopping executions could be returned
Waiting for all runs to complete before marking the run as stopping may cause this code to be executed simultaneously in multiple tasks and cause bugs related to the resources used by the VMs. Solution: First set that the VM is stopping, then wait for all runs to complete.
github-actions
bot
added
the
BLACK
Calling `get_running_vm(...)` could return an execution that is in a stopping state, causing issues in the next steps of the process.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 34.74% 34.76% +0.02%
==========================================
Files 52 52
Lines 4738 4741 +3
Branches 553 554 +1
==========================================
+ Hits 1646 1648 +2
- Misses 3074 3075 +1
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Solution: Make `pool.get_running_vm` synchronous, remove the `async` before the definition of the function.
Solution: Reuse `pool.get_running_vm` that checks if the execution is being stopped.
|
Only CodeCov tests are failing |
nesitor
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.