Fix: Execution creation was not tested #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
force-pushed
the
hoh-test-create-vm
branch
3 times, most recently
from
f700d21
to
6319dfd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 35.44% 43.83% +8.38%
==========================================
Files 54 55 +1
Lines 4900 4944 +44
Branches 585 585
==========================================
+ Hits 1737 2167 +430
+ Misses 3140 2658 -482
- Partials 23 119 +96 ☔ View full report in Codecov by Sentry. |
hoh
force-pushed
the
hoh-test-create-vm
branch
2 times, most recently
from
45cb904
to
13ad705
Compare
github-actions
bot
added
the
BLACK
nesitor
reviewed
Mar 15, 2024
|
I managed to get the VM working, only one blocking issue left: # FIXME: This import fails to work in a VM when using pytest
from aleph.sdk.chains.remote import RemoteAccount |
|
Is there a way to test this locally? I'm trying with |
|
I added doc to run the tests in |
olethanh
reviewed
Apr 2, 2024
olethanh
requested changes
Apr 3, 2024
olethanh
reviewed
Apr 3, 2024
hoh
force-pushed
the
hoh-test-create-vm
branch
2 times, most recently
from
8d1fc3e
to
689d672
Compare
Solution: Add a test that creates a new VM execution and checks that it starts properly.
Solution: Accept a `pathlib.Path` as argument and convert as string.
Co-authored-by: Olivier Le Thanh Duong <[email protected]>
This tests that a VM from the aleph.im network can be downloaded and launched. Co-authored-by: ajin <[email protected]>
Solution: Modify hatch configuration to have the environmnent properly set up using the virtual environment builtin module https://hatch.pypa.io/1.3/plugins/environment/virtual/
It's a problem surfaced by another The visible problem was that the new exection test were hanging, inside the runtime, during the import at the line from aleph.sdk.chains.remote import RemoteAccount after some more investigative work, it was pin pointed to an inner import of eth_utils module (specifically eth_utils.network ) Second problem that made the first visible: in the runtime the pre-compiled bytecode, created during runtime creation in create_disk_image.sh was not used, which made the import of module slower. This surfaced the first problem. The cause of that second problem was that the init1.py code which run the user caude was not launched with the same optimization level as the pre-compiled bytecode and thus recompiled everything. (this is specified in the init1.py #! sheebang on the first line) Solution: Compile the bytecode with the same optimisation level (-o 2 ) as during run We haven't found out yet why the eth_utils.network import hang when it is not precompiler. But this fix the test hanging issue
…asyncio' Fix: async_sessionmaker was introduced in sqlachemy 2.0, ensure we have at least this version otherwhise it was using a older system package
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add a test that creates a new VM execution and checks that it starts properly.