Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Paths to fake data were broken by refactoring #559

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 6, 2024

This fixes the relative paths to the fake data files and directories.

This fixes the relative paths to the fake data files and directories.
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.74%. Comparing base (2401133) to head (da72145).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   34.74%   34.74%           
=======================================
  Files          52       52           
  Lines        4738     4738           
  Branches      553      553           
=======================================
  Hits         1646     1646           
  Misses       3074     3074           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

The diff includes modifications in several areas such as:

  • Changes to FAKE_DATA_PROGRAM, BENCHMARK_FAKE_DATA_PROGRAM, FAKE_DATA_MESSAGE, FAKE_DATA_DATA, FAKE_DATA_RUNTIME and FAKE_DATA_VOLUME paths.
  • Changes to the 'fake instance' message defined in examples/instance_message_from_aleph.json.
  • The VM IDs for testing purposes are also being modified, which could potentially impact tests or require deep understanding of the project architecture.

The changes might be complex and risky if not handled properly as they involve significant changes to paths in configuration files and potential impacts on other parts of the system. Only experienced developers should review this PR. The label 'BLACK' is recommended for this kind of PR.

Please note that the response was generated based on the provided diff and rules, but it may not fully capture all the complexity or impact of the changes. It's always a good practice to discuss these complex PRs with other developers before merging them into the main codebase.

@hoh hoh merged commit bd1a019 into main Mar 6, 2024
20 checks passed
@Psycojoker Psycojoker deleted the hoh-fix-fakedata-paths branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants