Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Benchmark command did not initialize or check settings #561

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 6, 2024

This could result in invalid settings being used by the software.

This could result in invalid settings being used by the software.
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 34.72%. Comparing base (2401133) to head (fd5e7ad).
Report is 2 commits behind head on main.

Files Patch % Lines
src/aleph/vm/orchestrator/cli.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   34.74%   34.72%   -0.02%     
==========================================
  Files          52       52              
  Lines        4738     4740       +2     
  Branches      553      553              
==========================================
  Hits         1646     1646              
- Misses       3074     3076       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Mar 6, 2024
@aleph-im aleph-im deleted a comment from github-actions bot Mar 6, 2024
@hoh hoh merged commit b497e9a into main Mar 6, 2024
19 of 21 checks passed
@Psycojoker Psycojoker deleted the hoh-benchmark-setup branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants