Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAKE_DATA_PROGRAM issue on instances. #572

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Mar 13, 2024

Fix: If the FAKE_DATA_PROGRAM variable have a default value, when we start the controllers, it takes that default value instead to avoid it, and it fails on the checks.

Solution: Put FAKE_DATA_PROGRAM variable to None by default.

…e start the controllers, it take that default value instead to avoid it, and it fails on the checks.

Solution: Put `FAKE_DATA_PROGRAM` variable to None by default.
@nesitor nesitor requested a review from hoh March 13, 2024 13:35
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.19%. Comparing base (3c56ddc) to head (7f4d057).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   35.19%   35.19%           
=======================================
  Files          53       53           
  Lines        4844     4844           
  Branches      572      572           
=======================================
  Hits         1705     1705           
  Misses       3120     3120           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh
Copy link
Member

hoh commented Mar 13, 2024

What about adding a boolean USE_FAKE_DATA instead ? Would that not make more sense ?

@nesitor
Copy link
Member Author

nesitor commented Mar 13, 2024

What about adding a boolean USE_FAKE_DATA instead ? Would that not make more sense ?

This will add another env variable to know, and we have lots.
I think that provide the None option by default makes more sense because we already specify that option as an argument when we want to use a fake program.

@hoh hoh merged commit fc2eae7 into main Mar 13, 2024
21 checks passed
@hoh hoh deleted the andres-fix-solve_instance_configuration branch March 13, 2024 14:14
Copy link

Failed to retrieve llama text: POST 404: File Not Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants