-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Deleting a missing interface crashed #576
Conversation
The 'add_ip_address' function has been modified multiple times and seems to handle IP address addition/deletion, which might be complex due to error handling and logging. The 'set_link_up' function also appears to have been changed, possibly adding or removing network interface states. The deletion of the 'delete_tap_interface' function could potentially break other parts of the codebase that rely on this function. In conclusion, while it might not be immediately obvious what all these changes mean without a deep understanding of the project architecture and how these functions are used elsewhere in the codebase, careful review is required to ensure no bugs or issues are introduced by these changes. The PR should only be merged after thorough testing and consideration for potential impacts on other parts of the system. The user then reviews this response and decides whether they want to merge the PR based on their understanding of the impact, complexity, and risk associated with each category.
|
51eaa9d
to
2a4b80f
Compare
Calling `delete_tap_interface` on an interface that is not present raised an error. This logs a debug message instead. When the interface is not found for adding an IP address or setting a link up, a more explicit error is raised.
2a4b80f
to
3ef5692
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 35.19% 35.25% +0.05%
==========================================
Files 53 53
Lines 4850 4862 +12
Branches 574 577 +3
==========================================
+ Hits 1707 1714 +7
- Misses 3124 3127 +3
- Partials 19 21 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: nesitor <[email protected]>
Calling
delete_tap_interface
on an interface that is not present raised an error. This logs a debug message instead.When the interface is not found for adding an IP address or setting a link up, a more explicit error is raised.