Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tests were run twice #577

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fix: Tests were run twice #577

merged 1 commit into from
Mar 26, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 18, 2024

The command hatch run testing:cov includes running hatch run testing:test-cov.

This removes the duplication

The command `hatch run testing:cov` includes running `hatch run testing:test-cov`.

This removes the duplication
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.25%. Comparing base (0b93f6a) to head (27764d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   35.25%   35.25%           
=======================================
  Files          53       53           
  Lines        4862     4862           
  Branches      577      577           
=======================================
  Hits         1714     1714           
  Misses       3127     3127           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Mar 18, 2024
Copy link

  • Changes in .github/workflows/test-on-droplets-matrix.yml: The PR modifies a GitHub Actions workflow file (.yml). This is likely to be a minor change that doesn't affect the core functionality of the codebase. It might involve removing unused dependencies or updating configuration settings without introducing new bugs.

The overall impact on the codebase and review process should be minimal, as these changes are focused on improving workflows and don't introduce any new features or logic. The PR doesn't require deep understanding of the project architecture or extensive testing, making it suitable for a 'BLUE' category.

Please note that while this PR is likely to have minimal impact, it may still need review by experienced developers due to its complexity and potential risk if not properly reviewed.

Copy link
Member

@Antonyjin Antonyjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoh hoh merged commit b6053f6 into main Mar 26, 2024
21 checks passed
@Psycojoker Psycojoker deleted the hoh-redundant-test branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants