Added Qemu automatic tests #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Antonyjin
reviewed
May 3, 2024
Antonyjin
approved these changes
May 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 44.82% 51.71% +6.89%
==========================================
Files 55 57 +2
Lines 5033 5147 +114
Branches 589 591 +2
==========================================
+ Hits 2256 2662 +406
+ Misses 2654 2355 -299
- Partials 123 130 +7 ☔ View full report in Codecov by Sentry. |
# Conflicts: # .github/workflows/test-on-droplets-matrix.yml
nesitor
added a commit
that referenced
this pull request
May 27, 2024
* Feature: Added automatic tests to check if QEmu runs. * Fix: Added code quality fixes. * Testing basic instance Adding a test that start and stop a simple fake instance * Adding a test to create a simple instance Creating an instance locally using fake_data and checks if the execution start and stop properly. Doing the same checks with the VM created. * Fix: Black test did not pass Black check was failing Solution: Use black to format bad files * Fix: isort test did not pass isort check was failing Solution: Use isort to format bad files * Added Qemu automatic tests (#615) * Feature: Added automatic tests to check if QEmu runs. * Fix: Added code quality fixes. * Fix: Changed runtime generation script name. * Fix: Solve conflicts with main branch. * Fix: ruff test did not pass ruff check was failing Solution: Use ruff to format bad files * Fix: Branch `main` could not be tested easily This deploys the main branch automatically on the staging servers for system testing. * Fix: Unkwnown hashes raised exception Problem: Many crawlers called URLs that do not exist on CRNs. The current implementation raises an error when the hash of the VM cannot be found, which fills the logs on Sentry. Solution: Return an HTTP Not Found status instead. * Fix: Mypy was failing mypy was failing because I tried to stop an execution but did not checked if there was an existing execution Solution: Check first if there an execution and then stop and shutdown * Fix: Wrong image name inside the workflow * Fix: Wrong debian executable name inside workflow * Feature: Added automatic tests to check if QEmu runs. * Fix: Added code quality fixes. * Rebasing from main * Testing basic instance Adding a test that start and stop a simple fake instance * Adding a test to create a simple instance Creating an instance locally using fake_data and checks if the execution start and stop properly. Doing the same checks with the VM created. * Fix: Black test did not pass Black check was failing Solution: Use black to format bad files * Fix: isort test did not pass isort check was failing Solution: Use isort to format bad files * Fix: ruff test did not pass ruff check was failing Solution: Use ruff to format bad files * Fix: Mypy was failing mypy was failing because I tried to stop an execution but did not checked if there was an existing execution Solution: Check first if there an execution and then stop and shutdown * Rebasing from main * Fix: Incorrect path given in the workflow * Fix: Test use unknown user Instance test try to chmod a user named jailman that did not exist Solution: Creating the user jailman * unit test job cancelled, push again to check it * Fix: Job to create user jailman now is inside another job This job to create a new user do not need hes own job, we could just insert it in a previous job --------- Co-authored-by: Andres D. Molins <[email protected]> Co-authored-by: ajin <[email protected]> Co-authored-by: Hugo Herter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Added automatic tests to check if Qemu runs, also with network interface.
The tests bypass systemd manager to reduce complexity.
In later tests we will test the entire flow also using systemd.