-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform confidential directory on Settings #618
Conversation
…ficates generated by sevctl. Solution: Set that directory field on settings class and ensure to create the folder on initialization step.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 57.92% 57.95% +0.03%
==========================================
Files 60 60
Lines 5402 5406 +4
Branches 600 601 +1
==========================================
+ Hits 3129 3133 +4
Misses 2133 2133
Partials 140 140 ☔ View full report in Codecov by Sentry. |
I'm not actually sure we would need a decitated dir for the certificates, Platform certificate we can just generate in a temporary file or in the main aleph dir (there is only one file now) and certificate we get for the VM should go in the VM directory. |
I think that is better to have it cached, to avoid request it all the time |
good point |
If this data is cached, should it be in if not self.CONFIDENTIAL_DIRECTORY:
self.CONFIDENTIAL_DIRECTORY = self.CACHE_ROOT / "confidential" |
|
Problem: The server doesn't have a directory to save the platform certificates generated by
sevctl
.Solution: Set that directory field on settings class and ensure to create the folder on initialization step.