Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Binary sevctl was absent from debian packages #629

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

hoh
Copy link
Member

@hoh hoh commented Jun 5, 2024

Solution: Build sevctl using an upstream version of Rust (the version in Debian is not supported), and bundle it in the Debian packages.

Add a setting in aleph-vm with the path of the bundled binary.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.73%. Comparing base (d1a1497) to head (e48ca5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files          62       62           
  Lines        5481     5482    +1     
  Branches      608      608           
=======================================
+ Hits         3219     3220    +1     
  Misses       2122     2122           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but shouldn't we do some kind of caching for this not not agravate the CI time further

@hoh hoh marked this pull request as draft June 14, 2024 10:47
@olethanh
Copy link
Collaborator

Test are failing

error: could not find `Cargo.toml` in `/opt/packaging/sevctl` or any parent directory
make: *** [Makefile:51: target/sevctl] Error 101
make: *** [Makefile:93: all-podman-debian-12] Error 2
ls: cannot access 'packaging/target': No such file or directory

@aleph-im aleph-im deleted a comment from github-actions bot Jun 14, 2024
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we enable git submodules on the repo, maybe we need to also add it on the docs.

@hoh hoh marked this pull request as ready for review June 18, 2024 13:04
hoh added 3 commits June 18, 2024 15:07
Solution: Build `sevctl` using an upstream version of Rust (the version in Debian is not supported), and bundle it in the Debian packages.

Add a setting in aleph-vm with the path of the bundled binary.
@hoh hoh merged commit 377b77f into main Jun 19, 2024
24 checks passed
@hoh hoh deleted the hoh-package-sevctl branch June 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants