Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable printing system logs on deb package as per default configuration recommendation #640

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

aliel
Copy link
Member

@aliel aliel commented Jun 19, 2024

@aliel aliel requested a review from hoh June 19, 2024 18:32
@hoh
Copy link
Member

hoh commented Jun 19, 2024

These logs are indeed not so useful anymore for debugging, at least not enough to be enabled by default.

@hoh hoh merged commit 4060e00 into main Jun 19, 2024
22 of 23 checks passed
@nesitor
Copy link
Member

nesitor commented Jun 19, 2024

These logs are indeed not so useful anymore for debugging, at least not enough to be enabled by default.

This is not true, we are using also this line for printing SystemD logs on instances. So maybe we need to add another argument to print that systemd logs.

Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@hoh
Copy link
Member

hoh commented Jun 20, 2024

Hum... I should not have merged this so late in the evening, gonna review this more in details.

@Psycojoker Psycojoker deleted the aliel-disable-print-system-logs branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants