Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json logs endpoint which works for finished execution #718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Nov 5, 2024

Add a endpoint to get log from program from history, even after they have run.

Related ClickUp, GitHub or Jira tickets : ALEPH-275

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.

Changes

add /control/machine/{ref}/logs.json

How to test

Use the related branch in the client ol-ALEPH-275-info-program-boot+

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.87%. Comparing base (7461a49) to head (b887add).

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/metrics.py 25.00% 3 Missing ⚠️
src/aleph/vm/orchestrator/views/operator.py 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   62.59%   62.87%   +0.27%     
==========================================
  Files          69       69              
  Lines        6152     6201      +49     
  Branches      500      503       +3     
==========================================
+ Hits         3851     3899      +48     
+ Misses       2151     2148       -3     
- Partials      150      154       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh olethanh changed the title Add json logs endpoint which allow for past record Add json logs endpoint which works for finished execution Nov 5, 2024
@olethanh olethanh requested a review from nesitor November 5, 2024 18:19
@olethanh olethanh force-pushed the ol-ALEPH-275-info-program-boot branch from 3f29f1d to b887add Compare November 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant