Feature: VRF coordinator API and library. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested changes
Aug 31, 2023
utils.py
Outdated
| return random_hash == sha3_256(random_bytes + int_to_bytes(nonce)).digest() |
There was a problem hiding this comment.
Could you write some unit tests for functions like this one? VRFs are gonna be one of these features where we publish it then touch it only once in a while, without tests it's gonna be a pain to maintain.
The project is now structured as an `aleph_vrf` module that contains the coordinator and executor code. Added setup files using PyScaffold and a structure to run unit tests with pytest. Added a CI/CD pipeline for these unit tests.
odesenfans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.