Fix: pad numbers to requested size before XOR-ing them #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: rebuilding the random number from the random bytes in the executor responses does not work when the generated random number is smaller than the requested number of bytes. This occurs because the random number is not padded before being XOR-ed with the others. Solution: pad the random number of each executor to guarantee that it is N bytes wide.
odesenfans
force-pushed
the
od-pad-random-number-when-xor-ing
branch
from
876eae6
to
f03ca98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: rebuilding the random number from the random bytes in the executor responses does not work when the generated random number is smaller than the requested number of bytes. This occurs because the random number is not padded before being XOR-ed with the others.
Solution: pad the random number of each executor to guarantee that it is N bytes wide.