-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare executor VMs #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hoh approve plz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions regarding the logic here:
- Why use an
unauthorized_list
of nodes that did not respond instead of anauthorized_list
of nodes that did respond ? - Can you explain the motivation to hardcode this list in the function squashfs ? I assume that it is for transparency reasons, but that should be explained somewhere else we'll never remember in a few months...
- I don't see any docstring on the new functions to explain what we use them for and what they do on a high level. Can you add this ?
Apart from these 3 questions, I made some suggestions to improve the quality of the code with suggestions that you should just be able to apply on the code.
1.- Because if we use an 2.- You need to hardcode the list to use it inside of the function. Yes, you can load the list as a volume also, but this should be done as another future, and also ensure to publish the list independently, that will complicate the deployment. 3.- Indeed I don't added so much important methods, and all are used inside of the logic. The important |
…xecutor functions. Feature: Added a preload script of the executor function to candidate CRNs, and if the CRN doesn't respond, add it to unauthorized_node_list file.
23b120e
to
05e6938
Compare
Could this help with some of the VRF problems we encountered recently @nesitor ? |
# Conflicts: # deployment/deploy_vrf_vms.py
…ython 3.8 version.
Problem: Launch executor VMS the first time, take some time for new executor functions.
Feature: Added a preload script of the executor function to candidate CRNs, and if the CRN doesn't respond, add it to unauthorized_node_list file.