Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALEPH-80] feat/refactor: simplify instance creation chain switching #105

Merged
merged 21 commits into from
Nov 12, 2024
Merged

[ALEPH-80] feat/refactor: simplify instance creation chain switching #105

merged 21 commits into from
Nov 12, 2024

Conversation

gmolki
Copy link
Member

@gmolki gmolki commented Oct 16, 2024

No description provided.

@gmolki gmolki requested a review from amalcaraz October 16, 2024 10:32
@gmolki gmolki self-assigned this Oct 16, 2024
@gmolki gmolki force-pushed the refactor/ALEPH-80-simplify-instance-creation-chain-switching branch from b021cab to 901898c Compare October 24, 2024 12:02
@gmolki gmolki force-pushed the refactor/ALEPH-80-simplify-instance-creation-chain-switching branch from 901898c to 2ef9342 Compare October 24, 2024 12:41
amalcaraz
amalcaraz requested changes Oct 28, 2024
View reviewed changes
src/components/form/SelectPaymentMethod/cmp.tsx Outdated Show resolved Hide resolved
src/components/form/SelectPaymentMethod/cmp.tsx Show resolved Hide resolved
src/hooks/pages/computing/useNewInstancePage.ts Show resolved Hide resolved
src/components/form/SelectPaymentMethod/cmp.tsx Outdated Show resolved Hide resolved
src/components/pages/computing/NewInstancePage/cmp.tsx Outdated Show resolved Hide resolved
src/hooks/common/useConnection.ts Outdated Show resolved Hide resolved
src/components/pages/computing/NewInstancePage/cmp.tsx Show resolved Hide resolved
src/hooks/pages/computing/useNewInstancePage.ts Show resolved Hide resolved
@gmolki gmolki requested a review from amalcaraz October 29, 2024 17:09
@gmolki
Copy link
Member Author

gmolki commented Oct 30, 2024 •
edited
Loading

add4580 deployed in https://bafybeic25nhulzi6glahd347pc55frwl6dyimvmoqyol3zzz6qbhdelzwa.ipfs.aleph.sh/

@gmolki
Copy link
Member Author

gmolki commented Oct 31, 2024

1f172ae deployed in https://bafybeigv5govag2spamgu5isysb6dfl3vinbm4ws4ycy3oxfsjcgl2qtzm.ipfs.aleph.sh/computing/instance/new/

amalcaraz
amalcaraz approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@amalcaraz amalcaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmolki gmolki merged commit 9500f9d into main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amalcaraz amalcaraz amalcaraz approved these changes

Assignees

@gmolki gmolki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmolki @amalcaraz