Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a retry mechanism for custom domains #72

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Add a retry mechanism for custom domains #72

merged 6 commits into from
Oct 18, 2023

Conversation

BjrInt
Copy link
Member

@BjrInt BjrInt commented Oct 11, 2023

This feature allow users to revalidate their custom domain if the DNS check has failed. It works by sending a new aggregate message with a timestamp (to force an update).

@BjrInt BjrInt marked this pull request as ready for review October 13, 2023 14:19
@BjrInt BjrInt requested a review from amalcaraz October 13, 2023 14:22
@BjrInt
Copy link
Member Author

BjrInt commented Oct 13, 2023

I am aware that duplicating the same content inside of the <StatusLabel> is not ideal, but we also need this content to be customized.
Maybe by putting a default content for the 3 possible variants that's replaced when children are passed.

I'm also aware of the weird pattern on the default value for an aggregate message that has no updated_at property.

@BjrInt BjrInt merged commit 1452cc6 into main Oct 18, 2023
1 check passed
@BjrInt BjrInt deleted the Fix/DomainRetry branch October 18, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant