Fix: Domain aggregate message for function/instance #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalcaraz
requested changes
Dec 29, 2023
aliel
force-pushed
the
Fix/ProgramDomainMessage
branch
from
3cd3250
to
d282d49
Compare
aliel
force-pushed
the
Fix/ProgramDomainMessage
branch
from
d282d49
to
911229a
Compare
aliel
force-pushed
the
Fix/ProgramDomainMessage
branch
from
5ab9190
to
6cb2865
Compare
aliel
force-pushed
the
Fix/ProgramDomainMessage
branch
from
6cb2865
to
81a4edc
Compare
|
I merged those changes into the web3 hosting branch, at this specific commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of the domain aggregate for program message (instance or function) is not implemented right. This fixes replaces
ipfswith the program type value, when linking a domain to a program.{ - "type": "ipfs", + "type": "program", "message_id": <item_hash>, updated_at: <ISO timestamp> [programType]: "FUNCTION" | "INSTANCE" }fixes #77