Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AccountPickers component #9

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Conversation

gmolki
Copy link
Member

@gmolki gmolki commented Jul 26, 2024

Summary

This PR creates a new AccountPickers component with all needed behaviours for connecting to an account and switching between networks.
Adding this component deprecates WalletPicker component, so it has been removed.

Demo

Videos with all variants of the component:

Twentysix

accountpickers.-.twentysix.mov

Aleph

accountpickers.-.aleph.mov

@gmolki gmolki requested a review from amalcaraz July 26, 2024 16:17
@gmolki gmolki self-assigned this Jul 26, 2024
@gmolki gmolki changed the title Feat: AccountPicker component feat: AccountPicker component Jul 26, 2024
@gmolki gmolki changed the title feat: AccountPicker component feat: AccountPickers component Jul 26, 2024
Copy link
Collaborator

@amalcaraz amalcaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted a few details.
Really great work overall!

src/components/index.ts Outdated Show resolved Hide resolved
src/components/modules/AccountPickers/cmp.tsx Outdated Show resolved Hide resolved
@gmolki gmolki requested a review from amalcaraz July 30, 2024 17:20
Copy link
Collaborator

@amalcaraz amalcaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amalcaraz amalcaraz merged commit 9e18f1f into main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants