-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Liquidity Provider Token to Token List #73
Conversation
I think the liquidity coins are left unverified in purpose even for Alph/usdt (?) Otherwise pools could be setup between the liquidity pools tokens and other tokens |
why not allow such pools ? also if a user want's to buy/sell liquidity - it's good to have those tokens verified. |
I get what you're saying, but Who are we to decide what people are allowed to do with any given token. To the blockchain, it's just a token. In terms of ayin, they could reject supporting pools of the sort you mention if they wanted. |
@AdamCooke00, let's add this for now since the token list is still small. We'll introduce new approaches to automatically cover liquidity tokens, ensuring we maintain a succinct list. This list will be loaded in many places, so it's crucial to keep it lightweight. For example, the extension wallet has a size limit and can't accommodate a large token list. |
Sounds good. Perhaps in the future some sort of token type id such that we can denote a liquidity token. Say something like: ALPH=0 |
It's good to have more features, but that means more manual checks, larger size of the data, etc. This simple token format follows the industry standard, which only contains the most necessary information. The other features could be added as extensions probably. |
Description
This PR adds an Ayin LP Token for the ALPH/SQRL Pair