Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sets AR for Android only if using GCC #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elpiel
Copy link

@elpiel elpiel commented Sep 11, 2023

Fixes an issue with Android builds with ndk version 25 and up (and possibly 24)
Related issue: #188
Related PR: #196

@alexcrichton
Copy link
Owner

I think this might perhaps be better for the cc crate? That it's returning get_ar and get_ranlib and one of them doesn't work seems like that's best fixed upstream if possible

@elpiel
Copy link
Author

elpiel commented Sep 18, 2023

I'll look into it. I haven't had the opportunity to see what cc does and if it's the right fix to go upstream.

@elpiel
Copy link
Author

elpiel commented Jan 6, 2024

@alexcrichton would you consider including this fix as I don't receive any feedback or comments on the issue I created upstream in cc?

@alexcrichton
Copy link
Owner

Ah ok, well at least an attempt was made!

Would you be up for helping out to get Android running on CI though in lieu of upstream support? I've had to disable all the Android CI support historically due to it bitrotting but if more Android-specific support is grown here then I think it would be best to get a CI builder up-and-running to ensure that it keeps working in the future again.

@elpiel
Copy link
Author

elpiel commented Jan 16, 2024

Yes, I can look into enabling the builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants