Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of readme.md #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

radjivF
Copy link

@radjivF radjivF commented Apr 28, 2016

I just correct the readme. You don't need to declare Blop, if you do you will have an injection error, Cheers

@kscc25
Copy link

kscc25 commented Oct 24, 2016

Why is that? Isn't Blob an Angular service?

@radjivF
Copy link
Author

radjivF commented Oct 24, 2016

I guess Blob is a javascript object http://www.javascripture.com/Blob

@kscc25
Copy link

kscc25 commented Oct 25, 2016

Yes, but it's not available on every browsers so we need to inject Blob polyfill

@radjivF
Copy link
Author

radjivF commented Oct 25, 2016

I got an injection error when I did it. The only way to make it work was to take out in the dependencies injection.

@kscc25
Copy link

kscc25 commented Oct 26, 2016

Load dist/angular-file-saver.bundle.js then you are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants