Skip to content

Commit

Permalink
rename the sentinel cause and ignore lint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Zeph Grunschlag committed Aug 2, 2023
1 parent b2e67de commit deec57e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions conduit/pipeline/pipeline.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ type pipelineImpl struct {
}

var (
errStopCause = errors.New("pipeline stopped")
stopCause = errors.New("pipeline stopped") //nolint:revive // this is a sentinel error
errImporterCause = errors.New("importer cancelled")
errProcessorCause = errors.New("processor cancelled")
errExporterCause = errors.New("exporter cancelled")
Expand Down Expand Up @@ -386,7 +386,7 @@ func (p *pipelineImpl) Init() error {
}

func (p *pipelineImpl) Stop() {
p.ccf(errStopCause)
p.ccf(stopCause)

Check warning on line 389 in conduit/pipeline/pipeline.go

View check run for this annotation

Codecov / codecov/patch

conduit/pipeline/pipeline.go#L389

Added line #L389 was not covered by tests
p.wg.Wait()

if p.profFile != nil {
Expand Down
6 changes: 2 additions & 4 deletions e2e_tests/src/e2e_conduit/subslurp.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@
logger = logging.getLogger(__name__)

# Matches conduit log output:
# "FINISHED Pipeline round: 110. UPDATED Pipeline round: 111"
FINISH_ROUND: re.Pattern = re.compile(
b"FINISHED Pipeline round: (\d+). UPDATED Pipeline round"
)
# "UPDATED Pipeline NextRound=111. FINISHED Pipeline round r=110 (23 txn) exported in 1.23435sec"
FINISH_ROUND: re.Pattern = re.compile(b"FINISHED Pipeline round r=(\d+)")


class subslurp:
Expand Down

0 comments on commit deec57e

Please sign in to comment.