API: Don't return a top level array from algod #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
approved these changes
May 19, 2023
algochoi
approved these changes
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #5404 +/- ##
==========================================
- Coverage 55.38% 54.29% -1.10%
==========================================
Files 452 452
Lines 63812 63816 +4
==========================================
- Hits 35344 34648 -696
- Misses 26035 26711 +676
- Partials 2433 2457 +24
... and 61 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
changed the title
tzaffi
pushed a commit
to tzaffi/go-algorand
that referenced
this pull request
May 22, 2023
wip netdeploy: Copy ledger directory for kv tracker database (algorand#5392) assembler: Error if extra args are present in pragmas (algorand#5400) ledger: Exclude stake at R-320 that is expired by R (algorand#5403) Co-authored-by: cce <[email protected]> algod: Don't return a top level array from algod (algorand#5404) revert go get github.com/algorand/[email protected] go get github.com/getkin/[email protected] go mod tidy -compat=1.17 go get github.com/algorand/[email protected] go mod tidy -compat=1.17 go get github.com/algorand/[email protected] revert to master github.com/getkin/kin-openapi v0.117.0 github.com/getkin/kin-openapi v0.117.0 github.com/getkin/kin-openapi v0.117.0 go get golang.org/x/mod/modfile tidy #0 go get github.com/algorand/[email protected] go mod tidy tidy up after every go get simplify revert tidier tg tg
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converted response type from top level array to an object containing a single array entry.
See algorand/generator#36 for background on why this is a problem.
Test Plan
Updated unit tests-also updating cucumber tests for SDKs with generated responses from running code locally.