fix: correct the readonly handling

algorandfoundation · Nov 11, 2024 · 65c4e36 · 65c4e36
1 parent e7ec65a
commit 65c4e36
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/transaction/transaction.spec.ts b/src/transaction/transaction.spec.ts
@@ -321,10 +321,14 @@ const tests = (version: 8 | 9) => () => {
     })
 
     test('addressBalance', async () => {
-      appClient.send.call({
+      const result = await appClient.send.call({
         method: 'addressBalance',
         args: [algosdk.generateAccount().addr],
+        onComplete: algosdk.OnApplicationComplete.NoOpOC,
       })
+
+      // Ensure the transaction was not sent via simulate
+      await fixture.context.waitForIndexerTransaction(result.txIds[0])
     })
   })
 }

diff --git a/src/types/app-client.ts b/src/types/app-client.ts
@@ -1304,8 +1304,8 @@ export class AppClient {
       call: async (params: AppClientMethodCallParams & CallOnComplete & SendParams) => {
         // Read-only call - do it via simulate
         if (
-          params.onComplete === OnApplicationComplete.NoOpOC ||
-          (!params.onComplete && getArc56Method(params.method, this._appSpec).method.readonly)
+          (params.onComplete === OnApplicationComplete.NoOpOC || !params.onComplete) &&
+          getArc56Method(params.method, this._appSpec).method.readonly
         ) {
           const result = await this._algorand
             .newGroup()