Skip to content

Commit

Permalink
chore: Updating todos for application client
Browse files Browse the repository at this point in the history
  • Loading branch information
robdmoore committed Mar 24, 2023
1 parent 9edb232 commit 83af190
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/types/application-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ export class ApplicationClient {
private _approvalSourceMap: SourceMap | undefined
private _clearSourceMap: SourceMap | undefined

// todo: process ABI args as needed to make them nicer to deal with like beaker-ts
// todo: support unwrapping a logic error and source map.
// todo: support readonly method calls
// todo: support different oncomplete for create
// todo: find create, update, delete, etc. methods from app spec
// todo: intelligent version management

/**
* Create a new ApplicationClient instance
* @param appDetails The details of the app
Expand Down Expand Up @@ -177,8 +184,6 @@ export class ApplicationClient {
this._appAddress = algosdk.getApplicationAddress(this._appId)
this.sender = sender
this.params = params

// todo: find create, update, delete, etc. methods from app spec
}

/**
Expand Down Expand Up @@ -228,7 +233,6 @@ export class ApplicationClient {
clearStateProgram: clear,
metadata: {
name: this._appName,
// todo: intelligent version management
version: version ?? '1.0',
updatable:
allowUpdate ?? approval.includes(UPDATABLE_TEMPLATE_NAME)
Expand Down Expand Up @@ -417,10 +421,6 @@ export class ApplicationClient {
throw new Error(`Attempt to call an app that can't be found '${this._appName}' for creator '${this._creator}'.`)
}

// todo: process ABI args as needed to make them nicer to deal with like beaker-ts
// todo: support unwrapping a logic error and source map.
// todo: support readonly method calls

try {
return callApp(
{
Expand Down

0 comments on commit 83af190

Please sign in to comment.