Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include schema in AppClient's create params #250

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: Include schema in AppClient's create params #250

merged 1 commit into from
Mar 19, 2024

Conversation

tristanmenzel
Copy link
Contributor

@tristanmenzel tristanmenzel commented Mar 19, 2024 •
edited
Loading

Proposed Changes

  • Include schema in appclient's create params

Fixes #251

@tristanmenzel tristanmenzel force-pushed the fix/include-schema-in-create-call branch 2 times, most recently from 679e9d5 to e60634e Compare March 19, 2024 17:39
@tristanmenzel tristanmenzel mentioned this pull request Mar 19, 2024
Merged
robdmoore
robdmoore reviewed Mar 19, 2024
View reviewed changes
src/types/app-client.ts Outdated Show resolved Hide resolved
robdmoore
robdmoore reviewed Mar 19, 2024
View reviewed changes
src/types/app-client.ts Outdated Show resolved Hide resolved
robdmoore
robdmoore reviewed Mar 19, 2024
View reviewed changes
src/types/app-client.ts Outdated Show resolved Hide resolved
@robdmoore
Copy link
Contributor

robdmoore commented Mar 19, 2024 •
edited
Loading

Checking: these will both flow through to the typed client automatically yeah?

@tristanmenzel
Copy link
Contributor Author

@robdmoore algorandfoundation/algokit-client-generator-ts#104

@tristanmenzel tristanmenzel force-pushed the fix/include-schema-in-create-call branch from 7336a2c to c1dafda Compare March 19, 2024 17:58
@tristanmenzel tristanmenzel merged commit ba76728 into main Mar 19, 2024
2 checks passed
@tristanmenzel tristanmenzel deleted the fix/include-schema-in-create-call branch March 19, 2024 18:24
@neilcampbell neilcampbell mentioned this pull request Mar 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdmoore robdmoore robdmoore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Client does not allow you to specify extraPages for create calls
2 participants
@tristanmenzel @robdmoore