Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial setup #1

Merged
merged 12 commits into from
Sep 26, 2024
Merged

Initial setup #1

merged 12 commits into from
Sep 26, 2024

Conversation

iskysun96
Copy link
Collaborator

Changes made

  • added contributing guides
  • edited README
  • renamed subproject from devportal-code-examples to python-contract-examples

Request for @PhearZero :

  • Review Contributing guides
  • set up linting
  • set up CI/CD

PhearZero
PhearZero reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm sure it will go through some refinements as the process develops and this is a great start!

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
PhearZero
PhearZero approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕺!

@iskysun96 iskysun96 merged commit 3efe87a into main Sep 26, 2024
1 check passed
@CiottiGiorgio
Copy link
Member

Can we delete initial-setup branch now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskysun96 @CiottiGiorgio @PhearZero