Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: internal/accounts.go #15

Merged
merged 10 commits into from
Oct 29, 2024
Merged

test: internal/accounts.go #15

merged 10 commits into from
Oct 29, 2024

Conversation

HashMapsData2Value
Copy link
Contributor

ℹ Overview

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

@HashMapsData2Value HashMapsData2Value changed the title ci: increase test cov test: internal/accounts.go Oct 28, 2024
PhearZero
PhearZero reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits and then it LGTM

internal/accounts_test.go Outdated Show resolved Hide resolved
internal/accounts_test.go Outdated Show resolved Hide resolved
@PhearZero PhearZero added the task label Oct 29, 2024
PhearZero
PhearZero approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhearZero PhearZero merged commit d7ec2cc into main Oct 29, 2024
1 check passed
@HashMapsData2Value HashMapsData2Value deleted the ci/increase-cov branch October 29, 2024 12:56
@PhearZero PhearZero added this to the Milestone 1 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.
2 participants
@HashMapsData2Value @PhearZero