Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: view transitions #24

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor: view transitions #24

wants to merge 14 commits into from

Conversation

PhearZero
Copy link
Member

@PhearZero PhearZero commented Nov 5, 2024 •
edited
Loading

ℹ Overview

  • refactors navigation
  • allows modal placement
  • allows colors with adornments

Screenshot from 2024-11-12 12-24-18
Screenshot from 2024-11-12 12-23-56
Screenshot from 2024-11-12 12-23-39
Screenshot from 2024-11-12 12-23-33
Screenshot from 2024-11-12 12-23-26

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

@PhearZero PhearZero added this to the Milestone 1 milestone Nov 5, 2024
@PhearZero PhearZero self-assigned this Nov 5, 2024
@PhearZero PhearZero changed the title Refactor/view transitions refactor: view transitions Nov 5, 2024
@PhearZero PhearZero mentioned this pull request Nov 5, 2024
Closed
1 task
@PhearZero PhearZero marked this pull request as ready for review November 6, 2024 20:29
@tasosbit
Copy link
Contributor

Can we try these changes in the delete key confirmation modal:

  • move Account Address up, over part key id
  • add newlines between the sections
Are you sure...

Account address:
ABC

Participation Key ID:
XYZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PhearZero PhearZero

Labels
refactor
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.
2 participants
@PhearZero @tasosbit