Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Android 14 service guide #39

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

PhearZero
Copy link
Member

ℹ Overview

  • simplifies and adds Android 14 guide

✅ Acceptance:

  • Conventional Commits
  • npm test:cov passes

@PhearZero PhearZero added the documentation Improvements or additions to documentation label Aug 27, 2024
@PhearZero PhearZero self-assigned this Aug 27, 2024
@PhearZero PhearZero requested a review from ehanoc August 27, 2024 22:41
val origin = "https://webauthn.guide"
val userId = "a2bd8bf7-2145-4a5a-910f-8fdc9ef421d3"

val keyPair = DP256.genDomainSpecificKeypair(derivedMainKey, origin, userId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explain how to process credentials, sign them with the new keys.

The diff of the commit is removing previous example; we could just add the signing with the P256 keys .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was relying on the official documentation, it has all of the basic details and didn't want to duplicate their efforts.

The previous examples where only a small part of the process. The P256 keys are java.security.KeyPair based and plug into the existing documentation.

How granular would you like to go with the docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very. Let's give as much info as possible so that they shouldn't need to go to other sources to have a basic example.

We can reference the official docs for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants