-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/connect rtc #8
Merged
Merged
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f0293a4
docs: add webrtc decision
PhearZero 0c7a935
feat: session status and webvitals performance increase
PhearZero 77353cd
feat: WebRTC with websocket signaling
PhearZero 9683478
fix: session adapter
PhearZero 6396c36
wip: adds basic message passing demo
PhearZero 785b999
Merge branch 'refs/heads/develop' into feat/connect-rtc
PhearZero da647ae
fix: test stubs
PhearZero fb021a4
test: add signals unit tests
PhearZero 1d88a24
refactor: add core module and enforce style guides
PhearZero d1a61e0
chore: cleanup docker files
PhearZero 1515c14
Merge branch 'refs/heads/feat/rekeyed-account-support' into feat/conn…
PhearZero 9203910
chore: cleanup demo application
PhearZero 102a55c
test: enforce linters and tests
PhearZero 9ce32c4
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
PhearZero 8d2f3f3
build: remove preinstall hooks
PhearZero 6c6a257
refactor: change call to offer
PhearZero 68e6cab
test: add signaling fixture for session
PhearZero af6b7e7
feat: js signaling client
PhearZero e98cedd
chore: lint fixes
PhearZero d59ff07
docs: update contrib and top level compose
PhearZero 6cc3eef
fix: patch service for docker
PhearZero 325edae
build: add ngrok to docker
PhearZero 3e34494
docs: cleanup config docs
PhearZero ce75747
chore: cleanup files and update README
PhearZero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# Overview | ||
|
||
Communicating across platforms in a decentralized manner | ||
|
||
## Decisions | ||
|
||
- Limit dependency on WebSockets to signaling | ||
- Allow bidirectional communication between peers | ||
- Enforce locality of device? | ||
|
||
## Implementation | ||
|
||
A WebSocket Service should establish the SDP handshake and emit ICE candidates for WebRTC clients. | ||
|
||
This implementation should replace Wallet Connect with the following sequence | ||
```mermaid | ||
sequenceDiagram | ||
participant Website | ||
participant Server | ||
participant Wallet | ||
Note over Website, Wallet: Link devices | ||
Website->>Server: GET Challenge Message | ||
Server->>Website: Send Challenge Message | ||
|
||
Website-->>Website: Display QR Connect Nonce | ||
Website->>Server: Subscribe to 'wss:link' | ||
Wallet->>Website: Scan QR Code | ||
Wallet->>Server: POST Nonce + Signature + Answer | ||
Server-->>Server: Validate Signature | ||
Server-->>Website: HTTPOnly Session | ||
Server->>Wallet: Ok Response + HTTPOnly Session | ||
Server->>Website: Emit to `wss:link` client | ||
Note over Website, Wallet: Passkeys/FIDO2 | ||
Website-->>Website: Continue FIDO2 Flow | ||
Wallet-->>Wallet: Continue FIDO2 Flow | ||
Note over Website, Wallet: Signaling Peer Offer/Answer | ||
Website-->>Server: Subscribe to 'wss:answer-${address}' | ||
Wallet-->>Server: Subscribe to 'wss:offer-${address}' | ||
|
||
Website-->>Website: Create Peer Offer & DataChannel | ||
Website-->>Server: POST Offer | ||
Server-->>Wallet: Emit Offer | ||
|
||
Wallet-->>Wallet: Create Peer Answer with Offer & DataChannel | ||
|
||
Wallet-->>Server: POST Answer | ||
Server-->>Website: Emit Answer | ||
Website-->>Website: Set Remote SDP | ||
Website-->>Website: Discover ICE Candidates | ||
Website->>Server: Emit candidates to `wss:offer-${address}` | ||
Server->>Wallet: Emit candidates to `wss:offer-${address}` | ||
Wallet-->>Wallet: Set Candidates | ||
Wallet-->>Wallet: Discover ICE Candidates | ||
Wallet->>Server: Emit candidates to `wss:answer-${address}` | ||
Server->>Website: Emit to `wss:answer` | ||
Website->>Website: Set Candidates | ||
|
||
``` | ||
|
||
*Note: This process may be deprecated in the future in favor of `libp2p` which allows for an agnostic discovery layer and also supports the WebRTC transport |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: CI | ||
on: [pull_request] | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [ 18.x, 20.x ] | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@master | ||
- name: Use Node.js | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- name: Install Dependencies | ||
run: npm install | ||
- name: Run Build | ||
run: npm run build | ||
- name: Lint Codebase | ||
run: npm run lint | ||
- name: Unit Tests with Coverage | ||
run: npm run test:cov |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
swagger-codegen-cli.jar | ||
|
||
.data | ||
.idea | ||
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. couldn't find any mention of this in the readme There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is mostly in the docs branch to limit merge conflicts with the unit tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
|
||
|
||
CODEGEN=swagger-codegen-cli.jar | ||
if [ -f $CODEGEN ]; then | ||
echo "Codegen already exists" | ||
else | ||
echo "Downloading codegen" | ||
wget https://repo1.maven.org/maven2/io/swagger/codegen/v3/swagger-codegen-cli/3.0.52/swagger-codegen-cli-3.0.52.jar -O swagger-codegen-cli.jar | ||
fi | ||
|
||
java -jar swagger-codegen-cli.jar generate -i http://localhost:3000/api-json -l typescript-fetch -o clients/liquid-auth-client-js/src/client | ||
java -jar swagger-codegen-cli.jar generate -i http://localhost:3000/api-json -l kotlin-client -o clients/liquid-auth-client-kotlin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# Overview | ||
|
||
Client JSON-RPC interfaces are generated from OpenAPI 3.0 specifications. | ||
All clients should mirror the same interfaces and include the same parameters (as much as possible). | ||
|
||
```typescript | ||
interface SignalClient { | ||
readonly url: string; // Origin of the service | ||
type: "offer" | "answer" // Type of client | ||
peerClient: RTCPeerConnection | PeerClient // Native WebRTC Wrapper/Interface | ||
socket: Socket // The socket to the service | ||
|
||
readonly authenticated: boolean; // State of authentication | ||
readonly requestId?: string; // The current request being signaled | ||
|
||
/** | ||
* Generate a Request ID | ||
*/ | ||
generateRequestId(): any; | ||
|
||
/** | ||
* Top level Friendly interface for signaling | ||
* @param args | ||
*/ | ||
peer(requestId: any, type: 'offer' | 'answer', config?: RTCConfiguration): Promise<void>; | ||
|
||
/** | ||
* Link a Request ID to this client | ||
* @param args | ||
*/ | ||
link(...args: any[]): Promise<LinkMessage>; | ||
|
||
/** | ||
* Wait for a desciption signal | ||
* @param args | ||
*/ | ||
signal(...args: any[]): Promise<string>; | ||
|
||
/** | ||
* Terminate the signaling session | ||
*/ | ||
close(): void | ||
|
||
|
||
/** | ||
* Listen to Interface events | ||
* @param args | ||
*/ | ||
on(...args: any[]): void; | ||
|
||
/** | ||
* Emit an event to the interface | ||
* @param channel | ||
* @param callback | ||
*/ | ||
emit(channel: string, callback: (...args: any[])=>void) | ||
|
||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"env": { | ||
"browser": true, | ||
"es2021": true, | ||
"node": true | ||
}, | ||
"parserOptions": { | ||
"project": "tsconfig.json", | ||
"sourceType": "module" | ||
}, | ||
"plugins": [ | ||
"@typescript-eslint/eslint-plugin", | ||
"eslint-plugin-tsdoc" | ||
], | ||
"extends": [ | ||
"plugin:@typescript-eslint/recommended", | ||
"plugin:prettier/recommended" | ||
], | ||
"rules": { | ||
"@typescript-eslint/no-explicit-any": "warn" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
lib | ||
docs | ||
|
||
# Logs | ||
logs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"singleQuote": true, | ||
"trailingComma": "all" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we enforce it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could if we remove the STUN/TURN servers but we would lose a decent percentage of devices behind symmetric NAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is enforced locality even possible if apple / chrome sync passkeys across devices?
Not sure about chrome but apple really doesn't adhere to the standard well
https://www.slashid.dev/blog/passkeys-deepdive/#:~:text=Passkeys%20and%20traditional%20platform%20authenticator,event%20of%20a%20device%20compromise.
"impossible to verify the device type used to generate a key, and hence the trustworthiness of the key and its metadata. In fact, the lack of an attestation statement means that you can’t prove the key has been stored, or even generated, safely because you can’t infer properties/provenance of the authenticator."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylebeee Enforcing locality of the WebRTC peer channel, limiting discovery to only local addresses (no STUN/TURN)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the decision is no enforcing locality we should remove this bullet IMO