Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: RTPInputV2 support weighted tag feature & sequence feature & negative sampler #297

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[feat]: RTPInputV2 support weighted tag feature & sequence feature & negative sampler #297

wants to merge 10 commits into from
+556 −109

Conversation

tiankongdeguiji
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ cosmozhang1995
✅ tiankongdeguiji
❌ dawn310826
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

CI PY3 TF25 Test Failed

@github-actions
Copy link

CI PY3 Test Failed

@github-actions
Copy link

CI Test Failed

@tiankongdeguiji tiankongdeguiji changed the title [feat]: add rtp fg to support negative sampler and batch sequence feature op [feat]: RTPInputV2 support weighted tag feature & sequence feature & negative sampler Oct 18, 2022
@github-actions
Copy link

CI PY3 TF25 Test Passed

@github-actions
Copy link

CI PY3 Test Failed

@github-actions
Copy link

CI PY3 TF25 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels Oct 19, 2022
chengmengli06
chengmengli06 requested changes Oct 21, 2022
View reviewed changes
easy_rec/python/input/odps_rtp_input_v2.py
indices_0_list.append(indices_0_item)
indices_1_list.append(indices_1_item)
indices_2_list.append(indices_2_item)
elif sfc.feature_type == RtpFeatureType.RAW_FEATURE:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each feature type in a separate function?

@github-actions
Copy link

CI PY3 TF25 Test Passed

@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot removed the ci_test_passed ci test passed label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengmengli06 chengmengli06 chengmengli06 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci_py3_tf25_test_passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiankongdeguiji @CLAassistant @chengmengli06 @cosmozhang1995 @dawn310826