增加新选项 --wall #2905
Merged
增加新选项 --wall #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengyunabc
reviewed
Sep 25, 2024
site/docs/doc/profiler.md
Outdated
| 可使用以下命令（可以独立设置 CPU 和 Wall clock 分析的间隔）： | ||
|
|
||
| ```bash | ||
| profiler start -e cpu -i 10ms --wall 200ms -f out.jfr |
There was a problem hiding this comment.
这个使用文档有问题，命令会执行失败。
Error during processing the command: com.taobao.middleware.cli.CLIException, message:Cannot inject value for option 'interval'
|
从原来的 issue 来看， wall 是支持指定时间的，但这个 pr 里， wall 是一个 true/false ，这个貌似不太对。 |
# Conflicts: # site/docs/doc/profiler.md # site/docs/en/doc/profiler.md
|
修改成Long读取，单位为ms； |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
根据 async-profiler issue #740 的描述，这个 PR 引入了一个新特性，允许同时进行 CPU 和 Wall clock 的联合分析。