-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #10734] Implemented the parameter validation utility class #10737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from its subclasses to the parent class,to reduce the number of corresponding parameter extractors by .
…terface and the abstract classes HttpParamExtractor and RpcParamExtractor, implement the corresponding Manager.
KomachiSion
requested changes
Jul 6, 2023
api/src/main/java/com/alibaba/nacos/api/config/remote/request/ConfigPublishRequest.java
Outdated
Show resolved
Hide resolved
KomachiSion
requested changes
Jul 6, 2023
KomachiSion
previously approved these changes
Jul 6, 2023
…t test of ParamExtractorManager
KomachiSion
requested changes
Jul 6, 2023
auth/src/main/java/com/alibaba/nacos/auth/parser/grpc/NamingGrpcResourceParser.java
Outdated
Show resolved
Hide resolved
KomachiSion
approved these changes
Jul 7, 2023
wukong121
pushed a commit
to wukong121/nacos
that referenced
this pull request
Aug 4, 2023
…ass (alibaba#10737) * For alibaba#10734,Refactor the AbstractConfigRequest ,move common properties from its subclasses to the parent class,to reduce the number of corresponding parameter extractors by . * For alibaba#10734,add ParamCheckRules,ParamCheckUtils, add ParamExtractor interface and the abstract classes HttpParamExtractor and RpcParamExtractor, implement the corresponding Manager. * For alibaba#10734,fix codestyle * For alibaba#10734,fix codestyle , move extractor and extractorManager to core directory * For alibaba#10734,fix codestyle * For alibaba#10734,fix dependency of common module * For alibaba#10734,fix codestyle and copyright * For alibaba#10734,fix pom codestyle and copyright * For alibaba#10734,fix pom codestyle and copyright * For alibaba#10734,fix copyright * For alibaba#10734,fix copyright * For alibaba#10734,fix bug caused by refactor of AbstractConfigRequest ,add ut test of ParamExtractorManager * For alibaba#10734,fix bug caused by refactor of AbstractConfigRequest --------- Co-authored-by: zhuoguang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Implement parameter validation utility class and ParameterExtractor interface for isuue #10734
Brief changelog
Refactor the AbstractConfigRequest to reduce the number of corresponding parameter extractors .
Implement ParamCheckRules,ParamCheckUtils, add ParamExtractor interface and the abstract classes HttpParamExtractor and RpcParamExtractor, implement the corresponding ExtractorManager.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.