Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10734] Implemented the parameter validation utility class #10737

Merged
merged 13 commits into from
Jul 7, 2023
Merged

[ISSUE #10734] Implemented the parameter validation utility class #10737

merged 13 commits into from
Jul 7, 2023

Conversation

Sunrisea
Copy link
Contributor

@Sunrisea Sunrisea commented Jul 6, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Implement parameter validation utility class and ParameterExtractor interface for isuue #10734

Brief changelog

Refactor the AbstractConfigRequest to reduce the number of corresponding parameter extractors .
Implement ParamCheckRules,ParamCheckUtils, add ParamExtractor interface and the abstract classes HttpParamExtractor and RpcParamExtractor, implement the corresponding ExtractorManager.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [Y] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [Y] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [Y] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [Y] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [Y] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

zhuoguang added 2 commits July 6, 2023 11:00
… from its subclasses to the parent class,to reduce the number of corresponding parameter extractors by .
…terface and the abstract classes HttpParamExtractor and RpcParamExtractor, implement the corresponding Manager.
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

common/pom.xml Outdated Show resolved Hide resolved
KomachiSion
KomachiSion previously approved these changes Jul 6, 2023
@KomachiSion KomachiSion merged commit ba8e0e2 into alibaba:develop Jul 7, 2023
6 checks passed
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
…ass (alibaba#10737)

* For alibaba#10734,Refactor the AbstractConfigRequest ,move common properties from its subclasses to the parent class,to reduce the number of corresponding parameter extractors by .

* For alibaba#10734,add ParamCheckRules,ParamCheckUtils, add  ParamExtractor interface and the abstract classes HttpParamExtractor and RpcParamExtractor, implement the corresponding Manager.

* For alibaba#10734,fix codestyle

* For alibaba#10734,fix codestyle , move extractor and extractorManager to core directory

* For alibaba#10734,fix codestyle

* For alibaba#10734,fix dependency of common module

* For alibaba#10734,fix codestyle and copyright

* For alibaba#10734,fix pom codestyle and copyright

* For alibaba#10734,fix pom codestyle and copyright

* For alibaba#10734,fix  copyright

* For alibaba#10734,fix  copyright

* For alibaba#10734,fix bug caused by refactor of AbstractConfigRequest ,add ut test of ParamExtractorManager

* For alibaba#10734,fix bug caused by refactor of AbstractConfigRequest

---------

Co-authored-by: zhuoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants