[ISSUE #12017] Add the console backend API for new section #12553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add history handling module
* Add service handling module * Add instance handling module
* Add user handling module * Add role handling module * Add permission handling module
* Add cluster handling module
* Fix the error by adding ApiType
KomachiSion
requested changes
Aug 28, 2024
| @RestController | ||
| @RequestMapping("/v3/console/auth/permission") | ||
| @ExtractorManager.Extractor(httpExtractor = ConfigDefaultHttpParamExtractor.class) | ||
| public class ConsolePermissionController { |
There was a problem hiding this comment.
Permission, User, Role controller should be in auth plugin module, should not in console module.
Because these api is from optional plugin
| * @return history config info | ||
| */ | ||
| @GetMapping | ||
| @Secured(action = ActionTypes.READ, signType = SignType.CONFIG) |
| */ | ||
| @GetMapping(value = "/configs") | ||
| @Secured(action = ActionTypes.READ, signType = SignType.CONFIG) | ||
| public Result<List<ConfigInfoWrapper>> getConfigsByTenant(@RequestParam("namespaceId") String namespaceId) |
There was a problem hiding this comment.
这个是历史查询里，在查询框下拉显示配置列表的接口，可以直接选择对应的配置项
| */ | ||
| @PutMapping | ||
| @Secured(action = ActionTypes.WRITE) | ||
| public Result<String> updateCluster(HttpServletRequest request) throws Exception { |
There was a problem hiding this comment.
这两个接口不是一个类型吧， updateCluster应该是naming模块的，更新服务下cluster元数据的。
前者应该是core模块的，获取nacos节点的信息吧？
There was a problem hiding this comment.
确实有误， updateCluster应该是naming模块的
There was a problem hiding this comment.
我将updateCluster放入了ConsoleServiceController中
|
另外， 有的接口是Form对象，有的接口是独立RequestParameter列举， 看下是不是能统一一下。 |
Dannyss18
approved these changes
Aug 31, 2024
| * @param search the type of search (accurate or blur) | ||
| * @return permission of a role | ||
| */ | ||
| @GetMapping("/list") |
RickonZhang0929
changed the title
…ction" This reverts commit 052112a.
* Updated ControllerV3 for auth section
* Add ApiType annotation * Transfer the updateCluster method * Fix Compilation Errors
KomachiSion
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For 12017
Add the console backend API for config section
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.