Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control plugin log fix #12669

Merged
merged 2 commits into from
Sep 27, 2024
Merged

control plugin log fix #12669

merged 2 commits into from
Sep 27, 2024

Conversation

godhth
Copy link
Contributor

@godhth godhth commented Sep 19, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12668

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@godhth godhth closed this Sep 20, 2024
@godhth godhth reopened this Sep 20, 2024
@KomachiSion
Copy link
Collaborator

CI can't pass, please fix it first.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (077750b) to head (b0f5037).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #12669   +/-   ##
==========================================
  Coverage      69.62%   69.62%           
  Complexity      9415     9415           
==========================================
  Files           1275     1275           
  Lines          41233    41233           
  Branches        4374     4374           
==========================================
  Hits           28707    28707           
  Misses         10447    10447           
  Partials        2079     2079           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077750b...b0f5037. Read the comment docs.

@KomachiSion KomachiSion merged commit 76294a4 into alibaba:develop Sep 27, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.5.0 milestone Sep 27, 2024
@KomachiSion KomachiSion added area/Nacos Core kind/bug Category issues or prs related to bug. labels Sep 27, 2024
@KomachiSion KomachiSion modified the milestones: 2.5.0, 2.4.3 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos Core kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control plugin logback incorrect
3 participants