-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancment/update theme fragment #195
base: develop
Are you sure you want to change the base?
Changes from all commits
fca9535
4c815c6
ab0175b
af87dfa
1794d75
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,81 +1,102 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:app="http://schemas.android.com/apk/res-auto" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:orientation="vertical"> | ||
android:background="?attr/backgroundColor" | ||
android:orientation="vertical" | ||
android:padding="5dp"> | ||
|
||
<View | ||
android:id="@+id/header" | ||
android:layout_width="0dp" | ||
android:layout_height="35dp" | ||
android:layout_marginStart="8dp" | ||
android:layout_marginTop="8dp" | ||
android:layout_marginEnd="8dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
<androidx.constraintlayout.widget.ConstraintLayout | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:background="#FFFFFF"> | ||
|
||
<View | ||
android:id="@+id/background_view" | ||
android:layout_width="0dp" | ||
android:layout_height="170dp" | ||
android:layout_marginStart="8dp" | ||
android:layout_marginEnd="8dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintHorizontal_bias="0.0" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@+id/header" /> | ||
<View | ||
android:id="@+id/header" | ||
android:layout_width="0dp" | ||
android:layout_height="35dp" | ||
android:layout_marginStart="8dp" | ||
android:layout_marginTop="8dp" | ||
android:layout_marginEnd="8dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
|
||
<ImageView | ||
android:id="@+id/icon" | ||
android:layout_width="0dp" | ||
android:layout_height="0dp" | ||
android:layout_marginStart="16dp" | ||
android:layout_marginTop="32dp" | ||
android:layout_marginEnd="16dp" | ||
android:layout_marginBottom="32dp" | ||
app:layout_constraintBottom_toBottomOf="@+id/background_view" | ||
app:layout_constraintEnd_toEndOf="@+id/background_view" | ||
app:layout_constraintStart_toEndOf="@+id/timeline_line" | ||
app:layout_constraintTop_toBottomOf="@+id/theme_name" | ||
app:srcCompat="@drawable/ic_flower" /> | ||
<View | ||
android:id="@+id/background_view" | ||
android:layout_width="0dp" | ||
android:layout_height="170dp" | ||
android:layout_marginStart="8dp" | ||
android:layout_marginEnd="8dp" | ||
android:layout_marginBottom="8dp" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintHorizontal_bias="0.0" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@+id/header" /> | ||
|
||
<View | ||
android:id="@+id/timeline_line" | ||
android:layout_width="3dp" | ||
android:layout_height="0dp" | ||
android:layout_marginStart="20dp" | ||
android:background="?attr/timelineLineColor" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="@+id/header" /> | ||
<ImageView | ||
android:id="@+id/icon" | ||
android:layout_width="0dp" | ||
android:layout_height="0dp" | ||
android:layout_marginStart="16dp" | ||
android:layout_marginTop="32dp" | ||
android:layout_marginEnd="16dp" | ||
android:layout_marginBottom="32dp" | ||
app:layout_constraintBottom_toBottomOf="@+id/background_view" | ||
app:layout_constraintEnd_toEndOf="@+id/background_view" | ||
app:layout_constraintStart_toEndOf="@+id/timeline_line" | ||
app:layout_constraintTop_toBottomOf="@+id/theme_name" | ||
app:srcCompat="@drawable/ic_flower" /> | ||
|
||
<TextView | ||
android:id="@+id/theme_name" | ||
android:layout_width="0dp" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="8dp" | ||
android:layout_marginTop="8dp" | ||
android:layout_marginEnd="8dp" | ||
android:textAlignment="viewStart" | ||
android:textSize="14dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toEndOf="@+id/timeline_line" | ||
app:layout_constraintTop_toBottomOf="@+id/header" | ||
tools:text="January 19th, 2018" /> | ||
<View | ||
android:id="@+id/timeline_line" | ||
android:layout_width="3dp" | ||
android:layout_height="0dp" | ||
android:layout_marginStart="20dp" | ||
android:layout_marginBottom="8dp" | ||
android:background="?attr/timelineLineColor" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="@+id/header" /> | ||
|
||
<TextView | ||
android:id="@+id/logo" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:text="@string/presently" | ||
android:theme="@style/TextAppearance.Title" | ||
android:textSize="18dp" | ||
app:layout_constraintBottom_toBottomOf="@+id/header" | ||
app:layout_constraintEnd_toEndOf="@+id/header" | ||
app:layout_constraintStart_toStartOf="@+id/header" | ||
app:layout_constraintTop_toTopOf="@+id/header" /> | ||
<TextView | ||
android:id="@+id/theme_name" | ||
android:layout_width="0dp" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="8dp" | ||
android:layout_marginTop="8dp" | ||
android:layout_marginEnd="8dp" | ||
android:textAlignment="viewStart" | ||
android:textSize="14dp" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toEndOf="@+id/timeline_line" | ||
app:layout_constraintTop_toBottomOf="@+id/header" | ||
tools:text="January 19th, 2018" /> | ||
|
||
<TextView | ||
android:id="@+id/logo" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:text="@string/presently" | ||
android:textSize="18dp" | ||
android:theme="@style/TextAppearance.Title" | ||
app:layout_constraintBottom_toBottomOf="@+id/header" | ||
app:layout_constraintEnd_toEndOf="@+id/header" | ||
app:layout_constraintStart_toStartOf="@+id/header" | ||
app:layout_constraintTop_toTopOf="@+id/header" /> | ||
|
||
<ImageView | ||
android:id="@+id/selectIcon" | ||
android:layout_width="56dp" | ||
android:layout_height="42dp" | ||
android:layout_marginBottom="8dp" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:srcCompat="@android:drawable/checkbox_on_background" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think in order to merge this PR we'll need to find a different icon that matches the Presently style. I don't have the capacity right now to design something so this might have to wait a bit! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I thought so too. I had to get an icon on there for demonstration. We can change it once we find or design a suitable one. I'll leave that to you. |
||
|
||
</androidx.constraintlayout.widget.ConstraintLayout> | ||
|
||
</androidx.constraintlayout.widget.ConstraintLayout> | ||
</LinearLayout> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this
LinearLayout
needed for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alisonthemonster Hey, sorry for the late reply. It's used to create the border. The easiest implementation I know currently.