Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create strings.xml #203

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

kristy-hu
Copy link
Contributor

Create strings.xml for Simplified Chinese

@kristy-hu kristy-hu changed the title Create strings.xml for Simplified Chinese Create strings.xml Apr 22, 2021
<string name="language_sk">Slovák</string>
<string name="language_es">Español</string>
<string name="language_tr">Türkçe</string>
<string name="language_zh-cn">简体中文</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is unhappy because this name is invalid, how about language_zh_cn instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language_zh_cn is perfectly fine!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance I could hop on this? Thinking of forking @Kristie-Hu 's fork to make any necessary final edits, if they're not available atm!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been while... I'm not sure the app is currently still under maintenance, but maybe @wli-linda, you can help identify any issue with the xml, if you are free at the moment. :)
But actually looking back, I'd say language_zhCN might be a lot better than language_zh_cn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants