Enable strict_types across the project

alisqi · Oct 21, 2024 · 539ecd4 · 539ecd4
1 parent 09ad502
commit 539ecd4
Show file tree

Hide file tree

Showing 16 changed files with 19 additions and 19 deletions.
diff --git a/src/Assertion/AssertType.php b/src/Assertion/AssertType.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Assertion;
 

diff --git a/src/Assertion/AssertedTypesNode.php b/src/Assertion/AssertedTypesNode.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Assertion;
 

diff --git a/src/Assertion/WrapTypesInAssertedTypes.php b/src/Assertion/WrapTypesInAssertedTypes.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Assertion;
 

diff --git a/src/Extension.php b/src/Extension.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI;
 

diff --git a/src/Inspection/BadArgumentCountInMacroCall.php b/src/Inspection/BadArgumentCountInMacroCall.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Inspection;
 

diff --git a/src/Inspection/InvalidConstant.php b/src/Inspection/InvalidConstant.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Inspection;
 
@@ -36,10 +36,10 @@ private function checkArguments(FunctionExpression $node): void
         $location = "$sourcePath:{$node->getTemplateLine()}";
 
         if (count($arguments) === 1) {
-            $error = $this->checkConstant($arguments->getNode(0));
+            $error = $this->checkConstant($arguments->getNode('0'));
         } else {
             if (count($arguments) === 2) {
-                $error = $this->checkConstantAndObject($arguments->getNode(0), $arguments->getNode(1));
+                $error = $this->checkConstantAndObject($arguments->getNode('0'), $arguments->getNode('1'));
             } else {
                 $error = 'too many arguments';
             }
@@ -58,7 +58,7 @@ private function checkConstant(Node $node): ?string
 
         $value = $node->getAttribute('value');
 
-        if (!defined($value)) {
+        if (!is_string($value) || !defined($value)) {
             return "invalid constant: '$value'";
         }
 

diff --git a/src/Inspection/RequiredMacroArgumentAfterOptional.php b/src/Inspection/RequiredMacroArgumentAfterOptional.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Inspection;
 

diff --git a/src/Inspection/UndeclaredVariableInMacro.php b/src/Inspection/UndeclaredVariableInMacro.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Inspection;
 

diff --git a/src/Inspection/ValidTypes.php b/src/Inspection/ValidTypes.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Inspection;
 

diff --git a/tests/AbstractTestCase.php b/tests/AbstractTestCase.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Tests;
 

diff --git a/tests/BadArgumentCountInMacroCallTest.php b/tests/BadArgumentCountInMacroCallTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Tests;
 

diff --git a/tests/InvalidConstantTest.php b/tests/InvalidConstantTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Tests;
 

diff --git a/tests/RequiredMacroArgumentAfterOptionalTest.php b/tests/RequiredMacroArgumentAfterOptionalTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 use AlisQI\TwigQI\Tests\AbstractTestCase;
 

diff --git a/tests/TypeAssertionsTest.php b/tests/TypeAssertionsTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Tests;
 

diff --git a/tests/UndeclaredVariableInMacroTest.php b/tests/UndeclaredVariableInMacroTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Tests;
 

diff --git a/tests/ValidTypesTest.php b/tests/ValidTypesTest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 namespace AlisQI\TwigQI\Tests;