Fix: Table.BatchLoadTables interface cannot reload schema information correctly #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetchadd
requested changes
Oct 29, 2024
odps/table.go
Outdated
| @@ -76,10 +77,29 @@ func NewTable(odpsIns *Odps, projectName string, schemaName string, tableName st | |||
| } | |||
| } | |||
|
|
|||
| func NewTableWithModel(odpsIns *Odps, model *tableModel) (*Table, error) { | |||
There was a problem hiding this comment.
这个方法明显是内部用的，改成newTableWithModel
fetchadd
requested changes
Oct 29, 2024
dingxin-tech
force-pushed
the
fix/batch-reload-table
branch
from
47c9085
to
87df684
Compare
已 rebase master。每个 pr 使用独立的分支 |
fetchadd
requested changes
Oct 29, 2024
odps/tables.go
Outdated
| } | ||
|
|
||
| // BatchLoadTablesInSpecificSchema can get at most 100 tables, and the information of table is according to the permission | ||
| func (ts *Tables) BatchLoadTablesInSpecificSchema(tableNames []string, schemaName string) ([]*Table, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.