Feat: Streaming Tunnel supports Schema Evolution and provides related examples #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetchadd
requested changes
Oct 29, 2024
| @@ -54,6 +61,21 @@ func (rsw *RecordPackStreamWriter) Append(record data.Record) error { | |||
| return errors.WithStack(err) | |||
| } | |||
|
|
|||
| func checkIfRecordSchemaMatchSessionSchema(record *data.Record, schema []tableschema.Column) error { | |||
| if record.Len() != len(schema) { | |||
| return errors.New(fmt.Sprintf("Record schema not match session schema, record len: %d, session schema len: %d", | |||
| for index, recordData := range *record { | ||
| colType := schema[index].Type.ID() | ||
| if recordData != nil && recordData.Type().ID() != colType { | ||
| return errors.New(fmt.Sprintf("Record schema not match session schema, index: %d, record type: %s, session schema type: %s", |
| @@ -36,12 +36,15 @@ type sessionConfig struct { | |||
| // Columns for stream upload session only | |||
| Columns []string | |||
| SchemaVersion int | |||
| // AllowSchemaMismatch for stream upload session only | |||
| AllowSchemaMismatch bool | |||
There was a problem hiding this comment.
将AllowScheamaMismatch的配置项的作用添加到 CreateStreamUploadSession方法的注释里
fetchadd
requested changes
Oct 29, 2024
refactor: rename httpNotOk to httpError
dingxin-tech
force-pushed
the
feature/set_by_name
branch
from
a3296bd
to
ac1fafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.