Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing schedulerName definition to pod template #333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itaynvn-runai
Copy link

@itaynvn-runai itaynvn-runai commented Oct 20, 2024

What this PR does / why we need it:

when defining in values.yaml:

agentk8sglue:
  basePodTemplate:
    schedulerName: different-scheduler

the value isn't propagated to the configmap eventually created, and pods use the default-scheduler as a result.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Verify the work you plan to merge addresses an existing issue (If not, open a new one) (required)
  • Check your branch with helm lint (required)
  • Update version in Chart.yaml according semver rules (required)
  • Substitute annotations section in Chart.yaml annotating implementations (useful for Artifecthub changelog) (required)
  • Update chart README using helm-docs (required)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@itaynvn-runai itaynvn-runai changed the title Add missing schedulerName definition Added missing schedulerName definition to pod template Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant